Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding vcap_services class from frontend #89

Merged
merged 6 commits into from
Jul 20, 2023
Merged

Conversation

srh-sloan
Copy link
Collaborator

@srh-sloan srh-sloan commented Jul 6, 2023

Moving vcap services class from frontend into utils so it can be shared by other apps (assessment).

  • Unit tests and other appropriate tests added or updated
  • README and other documentation has been updated / added (if needed)
  • Commit messages are meaningful and follow good commit message guidelines (e.g. "FS-XXXX: Add margin to nav items preventing overlapping of logo")

How to test

If manual testing is needed, give suggested testing steps

Screenshots of UI changes (if applicable)

Copy link

@aaronwilliamsv1 aaronwilliamsv1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@srh-sloan srh-sloan dismissed aaronwilliamsv1’s stale review July 11, 2023 12:45

The merge-base changed after approval.

Copy link

@aaronwilliamsv1 aaronwilliamsv1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@srh-sloan srh-sloan dismissed aaronwilliamsv1’s stale review July 11, 2023 13:41

The merge-base changed after approval.

Copy link

@aaronwilliamsv1 aaronwilliamsv1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refreshed Cache, let's try that approval again

@srh-sloan srh-sloan dismissed aaronwilliamsv1’s stale review July 11, 2023 14:37

The merge-base changed after approval.

Copy link

@aaronwilliamsv1 aaronwilliamsv1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@srh-sloan srh-sloan dismissed aaronwilliamsv1’s stale review July 11, 2023 14:43

The merge-base changed after approval.

@srh-sloan srh-sloan dismissed aaronwilliamsv1’s stale review July 11, 2023 14:48

The merge-base changed after approval.

Adam-W1
Adam-W1 previously approved these changes Jul 11, 2023
@srh-sloan srh-sloan dismissed Adam-W1’s stale review July 11, 2023 15:09

The merge-base changed after approval.

adamdavies1
adamdavies1 previously approved these changes Jul 11, 2023
Copy link
Contributor

@adamdavies1 adamdavies1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tferns
tferns previously approved these changes Jul 20, 2023
@srh-sloan srh-sloan dismissed tferns’s stale review July 20, 2023 08:41

The merge-base changed after approval.

Copy link
Contributor

@gio-karunakaran gio-karunakaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏾

@srh-sloan srh-sloan dismissed gio-karunakaran’s stale review July 20, 2023 09:16

The merge-base changed after approval.

Copy link
Contributor

@gio-karunakaran gio-karunakaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@srh-sloan srh-sloan dismissed gio-karunakaran’s stale review July 20, 2023 09:37

The merge-base changed after approval.

Copy link
Contributor

@gio-karunakaran gio-karunakaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏾

@srh-sloan srh-sloan dismissed gio-karunakaran’s stale review July 20, 2023 10:04

The merge-base changed after approval.

tferns
tferns previously approved these changes Jul 20, 2023
@srh-sloan srh-sloan dismissed tferns’s stale review July 20, 2023 10:49

The merge-base changed after approval.

tferns
tferns previously approved these changes Jul 20, 2023
@srh-sloan srh-sloan dismissed tferns’s stale review July 20, 2023 10:56

The merge-base changed after approval.

@tferns tferns closed this Jul 20, 2023
@tferns tferns reopened this Jul 20, 2023
@tferns tferns merged commit 65afdf5 into main Jul 20, 2023
2 checks passed
@tferns tferns deleted the bau-vcap-services-utils branch July 20, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants